]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
AppIconMenu: properly destroy on source destroy.
authorMichele Gaio <micxgx@gmail.com>
Wed, 4 Nov 2015 00:56:16 +0000 (00:56 +0000)
committerFlorian Müllner <fmuellner@gnome.org>
Thu, 26 May 2016 23:03:25 +0000 (01:03 +0200)
If the source actor is destroyed while the popupMenu is shown -- this
can happen if a non favorite application was closing or crashes -- the
menu actor is improperly destroyed.

This makes the popupMenu close first and does a clean ungrab instead.

https://bugzilla.gnome.org/show_bug.cgi?id=757556

js/ui/appDisplay.js

index 58adf3a3265fbbd33b184265f00f611ed39e1a66..cae1757095bcc9cb97c86aaaa176e31783b47577 100644 (file)
@@ -1814,7 +1814,7 @@ const AppIconMenu = new Lang.Class({
             if (!source.actor.mapped)
                 this.close();
         }));
-        source.actor.connect('destroy', Lang.bind(this, function () { this.actor.destroy(); }));
+        source.actor.connect('destroy', Lang.bind(this, this.destroy));
 
         Main.uiGroup.add_actor(this.actor);
     },